Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): update terrain ranged data in parallel with cover update #4141

Merged

Conversation

chaosvolt
Copy link
Member

Purpose of change

This is meant as a parallel update to #4129 to avoid piling up even more changes in a single PR. Not dependent on it for anything, but the aim here is updating existing instances of terrain ballistic resistance to be consistent with that PR.

Describe the solution

  1. Updated ranged data of wooden doors to match the general trend of wooden objects having ballistic resistance more in line with how low their str_min is, and added destroy_threshold matching its str_max (used by most additions in the other PR except for fragile stuff like glass/ceramic/stone, for stuff that breaks in specific stages of varying fragility, or for sandbags).
  2. Updated damaged wood doors accordingly, and gave it a more fitting level of cover chance for the version with a hole knocked in it.
  3. Removed cover data from overhead light since obstacles not likely to be in front of you generally aren't being given cover data in the other PR.
  4. Updated it so shooting up a gas pump is consistent with wrecking consoles and other delicate breakable obstacles, and changed its cover rate for consistency.
  5. Increased cover value of cloning vats and updated their ballistic value to be consistent with glass terrain, bumped their bash_min up to not be way lower than other windows and the like, gave laser resistance and a cover chance.
  6. Updated the few wall-type terrains for consistency, with the different cover save for half/broken walls and more fragile glass for non-reinforced versions.
  7. Removed resistance from paper wall since bash resistance is so low, consistent with for example not giving cardboard and pillow forts ballistic resistance.
  8. Removed ballistic resistance from windows that don't have any bash resistance, since default is zero.

Describe alternatives you've considered

Giving all those extra cheapass windows bash data and ballistic stats to match. Having some take a token effort to break while others will always break seems weird to me, but that's out of scope for this PR.

Testing

Checked affected files for syntax and lint errors.

Additional context

Also jfc there are a lot of windows, doors, and the like where this feature is not implemented when SOME have it, and I feel like that's gonna have to be its own fucking thing auuugh.

The absurd variety of glazed layer windows at the end especially is going to fuuuucking suck to stat out...

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jan 20, 2024
@chaosvolt chaosvolt merged commit d84e345 into cataclysmbnteam:main Feb 7, 2024
8 of 9 checks passed
@chaosvolt chaosvolt deleted the take-cover-parallel-change-1 branch February 7, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants