Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(content): house_fence09 #4144

Merged
merged 1 commit into from
Jan 21, 2024
Merged

feat(content): house_fence09 #4144

merged 1 commit into from
Jan 21, 2024

Conversation

LilShiningMan
Copy link
Contributor

Purpose of change

more houses

Describe the solution

Describe alternatives you've considered

Testing

linted and spawned in game

Additional context

house_fence09_b
house_fence09_g
house_fence09_2
house_fence09_r

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jan 21, 2024
@scarf005 scarf005 changed the title feat(content): house_fence09 feat(content): house_fence09 Jan 21, 2024
scarf005
scarf005 approved these changes Jan 21, 2024
View reviewed changes
Copy link
Member

@scarf005 scarf005 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks neat, thanks!

also, could we wrap in-game keywords (e.g mapgen id) in backticks (`) in PR title next time to make them easily distinguishable?

image
this

image
becomes this

@scarf005 scarf005 merged commit e0d9c52 into cataclysmbnteam:main Jan 21, 2024
9 checks passed
@LilShiningMan
Copy link
Contributor Author

For sure, will try to remember for next time

@LilShiningMan LilShiningMan deleted the house_fence09 branch March 1, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scarf005 scarf005 scarf005 approved these changes

Assignees
No one assigned
Labels
JSON related to game datas in JSON format.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LilShiningMan @scarf005