Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): update uncrafts for small items #4147

Merged
merged 5 commits into from
Feb 4, 2024

Conversation

chaosvolt
Copy link
Member

Purpose of change

A bunch of clothing items have built-in salvage recipes due to salvage-by-weight fuckery that are basically a salvage recipe except they return an actual amount of material that exists. They generally works fine, though one major drawback is you can salvage in complete darkness, while the BLIND_HARD flag isn't actually enough to allow uncrafting in complete darkness.

Also turns out if the item is too small to salvage into anything it's automatically excluded, so some items need uncrafts added to them.

Describe the solution

  1. Gave all the armor uncrafts in json/uncraft/armor.json that use just a cutting tool the BLIND_EASY flag, which is what you need to actually mimic the full ability to salvage in the dark. Includes some uncrafts that were also dead simple as fuck but lacked a recipe flag entirely.
  2. Obsoleted uncrafts for t-shirts, compression shorts and top, their mass is actually high enough that they can be cut up.
  3. Added uncrafts for several items that have low enough mass to need it:
  • French maid hat
  • Loose versions of patchwork scarf and wool scarf
  • Leg warmers
  • Fetlock furs
  • Tabi and gi tabi
  • Sock mitts
  • Wrist holster, sheathes, and bandoliers
  1. Bumped weight of work t-shirt up to 100 grams so it wouldn't need a dedicated uncraft.
  2. Made the following recipes reversible:
  • Loincloths of all types
  • Cord sandals
  • All thermal electric items

Describe alternatives you've considered

  1. Making them all return an exact amount of thread fitting their weight.
  2. Implementing DDA's cotton scrap idea so this feature is slightly less annoying to work around.
  3. Trying to revive that big beefing up of item weights to make this less of a thing in the first place. It was pure fucking CBT to work on and it's kinda the hackiest solution, with even the uncraft method being less shitty a hack in comparison, so I'm not really eager to try that route.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Faffed about with loading a save to check removed uncrafts are obsoleted right, and that expected items can be salvaged.

Additional context

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jan 21, 2024
@scarf005 scarf005 merged commit 5a2e297 into cataclysmbnteam:main Feb 4, 2024
9 checks passed
@chaosvolt chaosvolt deleted the panty-destruction branch February 4, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants