fix: Fix overlapping text in look-around. #4156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines were being drawn on top of one another, making text unreadable. fixes cataclysmbnteam#4140, fixes cataclysmbnteam#3945
"point" constructor takes (x, y) and was being fed (y, x).
chaosvolt
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Lines of text within the look-around panel were being drawn on top of one another. Fixes #4140, Fixes #3945.
Describe the solution
Slightly reworked inconsistent line number accumulation/usage that was leading to overlap. In the whole call tree of the game::print_all_tile_info function, only game::print_terrain_info and game::print_visibility_info appeared to be problematic.
Testing
Started a new character and looked around at lighted tiles, dark tiles, tiles with stuff on them, with an NPC, etc. Seemed okay.