fix: reduce merchant item restock range #4164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Fixes #3980
Merchant NPCs are pulling all faction owned items within PICKUP_RANGE when restocking. If there are faction owned items in display cases they will disappear and not be replaced. Since merchants drop excess inventory at their feet we should only be picking up that inventory when restocking.
Describe the solution
Reduce range from
PICKUP_RANGEto0Describe alternatives you've considered
Make a "merchant hammerspace" alternative inventory so that merchant carried sales inventories can go into there without bringing back perf issues from being overburdened while carrying items in the personal inventories. Sorta like the inventory chests that NPCs access in Oblivion / Skyrim.