Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): updates to spawns of autodoc installation items #4170

Merged

Conversation

chaosvolt
Copy link
Member

Purpose of change

This makes a bit wider usage of bionic installation data cards, and breaks them up into two categories for ones that should show up in civilian contexts vs. more military/lab contexts.

Describe the solution

  1. Split up autodoc_installation_programs into a 60/40 split between two subgroups, basic and advanced. The former contains installation cards for stuff normally seen in bionics_common (with some occasional bionics_tech or bionics_sci cards), while the latter spawns the more unusual stuff typical in military and superscience locations.
  2. Changed the calls to installation cards in hospitals, doctors offices, and electronics stores to use autodoc_installation_programs_basic instead of the parent itemgroup.
  3. Added a chance for the general autodoc_installation_programs itemgroup to show up in lab/microlabs bionic vaults.
  4. Allowed the bionic lab finale loot spawn, military base bionics cache, and necropolis labs to spawn autodoc_installation_programs_advanced.

Describe alternatives you've considered

Adding an autodoc card for every bionic in the game, maybe also breaking them up into even more specific groups like common vs. tech vs. science vs. military and the like.

Testing

Checked affected files for syntax and lint errors.

Additional context

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jan 27, 2024
Copy link
Contributor

autofix-ci bot commented Jan 27, 2024

The Autofix app has found code style violation and automatically formatted this Pull Request.

I locally edit my commits (e.g: git, github desktop)

Please choose following options:

I'd like to accept the automated commit
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

This PR is complete and I don't want to edit it anymore

It's safe to ignore this message.

I edit this PR through web UI

You can ignore this message and continue working.

I have no idea what this message is talking about

You can ignore this message and continue working. If you find any problem, please ask for help and ping @scarf005.

@scarf005 scarf005 merged commit 74fcc7b into cataclysmbnteam:main Feb 4, 2024
9 checks passed
@chaosvolt chaosvolt deleted the bionic-install-data-grouping branch February 4, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants