-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add paddy field and soil-to-clay constr #4197
Conversation
The Autofix app has found code style violation and automatically formatted this Pull Request. I locally edit my commits (e.g: git, github desktop)Please choose following options: I'd like to accept the automated commit
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. This PR is complete and I don't want to edit it anymoreIt's safe to ignore this message. I edit this PR through web UIYou can ignore this message and continue working. I have no idea what this message is talking aboutYou can ignore this message and continue working. If you find any problem, please ask for help and ping @scarf005. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good but some suggestions mebbe
data/json/construction.json
Outdated
"required_skills": [ [ "survival", 1 ] ], | ||
"time": "20 m", | ||
"qualities": [ [ { "id": "DIG", "level": 1 } ] ], | ||
"components": [ [ [ "clay_lump", 8 ] ], [ [ "water", 4 ], [ "water_clean", 4 ] ], [ [ "material_sand", 1 ], [ "material_soil", 2 ] ] ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 soil is 5 liters, 1 sand is 5 ml. Suggestion here uses the same ratio that "Fill Shallow Water With Dirt" uses, which is still barely any but eh, doesn't have to be exact given that would require 2000 sand:
"components": [ [ [ "clay_lump", 8 ] ], [ [ "water", 4 ], [ "water_clean", 4 ] ], [ [ "material_sand", 1 ], [ "material_soil", 2 ] ] ], | |
"components": [ [ [ "clay_lump", 8 ] ], [ [ "water", 4 ], [ "water_clean", 4 ] ], [ [ "material_sand", 20 ], [ "material_soil", 2 ] ] ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this construction was about changing the composition of the soil to hold the water that the rice crop needs, but didn't consider volume of sand.
If "Fill Shallow Water With Dirt" requires 10 liters, it would be better to leave out the sand and just fill it with clay and dirt. Of course, to fill 5 liters with clay alone would require 20 clay, so it would need to be mixed with water. Maybe 4 to 6?
"components": [ [ [ "clay_lump", 8 ] ], [ [ "water", 4 ], [ "water_clean", 4 ] ], [ [ "material_sand", 1 ], [ "material_soil", 2 ] ] ], | |
"components": [ [ [ "clay_lump", 8 ] ], [ [ "water", 12 ], [ "water_clean", 12 ] ], [ [ "material_soil", 1 ] ] ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could work then, soil's more reliable to get than sand so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rice paddies require a hard layer of solid clay to trap water molecules in the pond. Sand is too porous to contain water so you want as much compacted clay as possible. There's a lot of research here but that's the jist of how a paddy field is done.
data/json/construction.json
Outdated
"required_skills": [ [ "survival", 2 ] ], | ||
"time": "90 m", | ||
"qualities": [ [ { "id": "DIG", "level": 1 } ] ], | ||
"byproducts": [ { "item": "pebble", "charges": [ 2, 16 ] } ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This I assume should probably be clay lumps instead of pebbles, and equal the amount of clay you get out of constr_extract_clay
?
"byproducts": [ { "item": "pebble", "charges": [ 2, 16 ] } ], | |
"byproducts": [ { "item": "clay_lump", "charges": [ 6, 12 ] } ], |
Co-authored-by: Chaosvolt <[email protected]>
Co-authored-by: Chaosvolt <[email protected]>
Co-authored-by: Chaosvolt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left clarification on rice paddies and on the clay extraction.
data/json/construction.json
Outdated
"required_skills": [ [ "survival", 1 ] ], | ||
"time": "20 m", | ||
"qualities": [ [ { "id": "DIG", "level": 1 } ] ], | ||
"components": [ [ [ "clay_lump", 8 ] ], [ [ "water", 4 ], [ "water_clean", 4 ] ], [ [ "material_sand", 1 ], [ "material_soil", 2 ] ] ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rice paddies require a hard layer of solid clay to trap water molecules in the pond. Sand is too porous to contain water so you want as much compacted clay as possible. There's a lot of research here but that's the jist of how a paddy field is done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot one
data/json/construction.json
Outdated
"byproducts": [ { "item": "clay_lump", "charges": [ 6, 12 ] } ], | ||
"components": [ [ [ "water", 32 ], [ "water_clean", 32 ] ] ], | ||
"pre_terrain": "t_clay_bog", | ||
"post_terrain": "t_clay" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"post_terrain": "t_clay" | |
"post_terrain": "t_dirt" |
Co-authored-by: Chaosvolt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accept to change t_clay
to t_dirt
, and adjust other things accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:3
Purpose of change
Add a paddy field and construction for gathering clay from soil.
Former is expansion of #4120, latter is for QoL.
No more struggles in order to finding clay.
Describe the solution
Construct a paddy field
Unlike a field, the composition of the soil in a paddy field is important. This is because the clay holds water and creates the right environment for crops like rice.
So I made it so that clay is required for construction. Since rice paddies are always planted on lower ground, I had them start with a shallow pit, and finally, just in case, I created a construction to remove it.
Gather more clay
Clay is in unexpectedly high demand.
Especially before you can make a clay crucible, or when you're out in the wild and can't find a pot and need to make a clay pot.
However, many of the methods of obtaining clay rely on luck, so to reduce that dependency for better QoL, I created this construction.
Put 50 unit soil and 64 water, then get your homemade clay terrain.
Describe alternatives you've considered
Testing
Additional context
I add
"iexamine_action": "dirtmound"
.It works well, but also allows other seeds which don't need
SHALLOW_WATER
flag.I can't decide to remove it or not.
Checklist