fix: uncrafts for lightweight plastic containers #4204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Realizing that I can't salvage gallon jugs has once again abruptly led me down a weird rabbit hole of screaming at salvage-by-weight.
Describe the solution
Since we've since decided to fudge the numbers for small underwear items and just let them be uncrafted into full rags, I added uncrafts for all plastic containers to convert them into a given number of plastic chunks (or scrap in the case of small bottles).
Describe alternatives you've considered
Testing
Additional context
I loaded up DDA (old build, 2023-12-16-1905) and looked at gallon jugs, they went with the "beef the weight up" solution. However, it only returns 2 chunks when salvaged but still demands 15 chunks PLUS a polycarbonate sheet, so it's just wasteful to a wacky degree.
Checklist