-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: differentiate more SPEAR
and STAB
flag
#4214
Conversation
SPEAR
and STAB
flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. I've also included migration script and documentation. Approving as local tests pass.
Items overlooked, as pointed out in my change request for the previous PR:
Since the addition of the flag to glaives and halberds got approved then lucerne hammer might be acceptable to add it to but still potentially borderline. If not, it needs |
Oh wait no, lucerne hammers did at least get the treatment so it's just Magiclysm items. |
Purpose of change
Note
same as #4211 due to branch issues
Splitting up "SPEAR" flag and "STAB" flag so they can be used separately, allowing the ability to reach attack through bars with cutting weapons that should be able to do it.
Describe the solution
"SPEAR" flag does not transform cut damage into pierce damage anymore, still allowing the ability to attack through bars with reach weapons, while only "STAB" flag change cut damage into pierce damage. Added the "STAB" flag to all weapons that previously had only "SPEAR" flag, so they continue do pierce damage, and added the "SPEAR" flag to some weapons that should be able to reach attack through bars, while still doing cut damage.
Describe alternatives you've considered
Not adding the "SPEAR" flag to any cut damage weapon, waiting for an actual flag/technique (need hardcode) to allow to cut damage weapons to do pierce damage while performing reach attack through bars.
Testing
Weapons with adjusted "SPEAR" and "STAB" flag work as inteded.
Additional context
Ideally, it would have more sense that weapons that do cut damage and can reach attack through bars, would do pierce damage while attacking through bars, and not continuing doing cut damage, but that would need follow-up PR to make it possible.
Checklist
If this is a C++ PR that modifies JSON loading or behavior:
doc/
folder.lang/bn_extract_json_strings.sh
script if it does not support them yet.