fix: quickfix for bash-related crashes #4237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Fix a case of nullpointer fuckery causing random crashes. Fixes #4236
Describe the solution
In map.cpp, set
map::smash_items
so the part of the check that looks forzombify_into
is properly nested behind anis_corpse
check, to avoid the risk thatget_mtype
will implode over something that won't have it.Describe alternatives you've considered
Screaming.
Testing
Additional context
Lemme know if I missed any other obvious fuckups.
Checklist