Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use mount's speed when mounted #4310

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Mar 7, 2024

Purpose of change

riding horse should be fast.

Describe the solution

use mounted animal's speed instead when mounted.

Describe alternatives you've considered

also take overburden or other stuff into account but was lazy.

Testing

image

  1. spawn horse, cattle fodder, horse tack
  2. ride on horse
  3. speed is now 300
  4. dismount from horse
  5. speed is now 100

@github-actions github-actions bot added the src changes related to source code. label Mar 7, 2024
@scarf005 scarf005 changed the title fix: mark idempotent monster getters as const feat: use mount's speed when mounted Mar 7, 2024
@scarf005 scarf005 requested a review from chaosvolt March 7, 2024 07:33
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nyoooooom

@scarf005 scarf005 merged commit 589ffa1 into cataclysmbnteam:main Mar 7, 2024
13 checks passed
@scarf005 scarf005 deleted the feat-mount-speed branch March 7, 2024 12:29
@scarf005
Copy link
Member Author

scarf005 commented Mar 7, 2024

btw this will make your horse effectively sandevistan because speed is applied to not only movement but everything else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants