Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: erase items in area #4313

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Mar 8, 2024

Purpose of change

make it easier to erase large number of items, e.g for perf reasons.

Describe the solution

choose rectangular area, iterate through points and erase items.

Describe alternatives you've considered

make item merging easier.

Testing

2024-03-08_17-46-20.mp4
  1. select debug/map/erase items in area.
  2. select grid.
  3. items are erased.

@github-actions github-actions bot added the src changes related to source code. label Mar 8, 2024
@scarf005 scarf005 requested a review from chaosvolt March 8, 2024 15:09
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this isn't already a thing mapgen transformations can do for mission things, being able to move or delete items via JSON would be a neat improvement for the future. Think we might already have that though.

@scarf005 scarf005 merged commit 2f32b55 into cataclysmbnteam:main Mar 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants