Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add no_hope to mod test blocklist #4327

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Mar 9, 2024

Purpose of change

  1. the mod overrides many things such as palettes.
  2. due to this, it causes countless test failures (like in feat(content): residential personal items  #4312)
  3. we lack staff to maintain it.

Describe the solution

ignore no_hope from testing for the time being.

Describe alternatives you've considered

extract the mod into third-party mod (cataclysmbn/no_hope)?

due to the mod overriding many things, it caused countless test failures, thus we're ignoring `no_hope` from testing for the time being.
@scarf005 scarf005 requested a review from chaosvolt March 9, 2024 22:34
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Counterpoint: No Hope being such a mess has enlightened me to there being a vastly more efficient way to check out people's branches and yeet fixes at their PRs than trying to deal with VS2019 and the ghosts currently haunting my version of it. :3

@scarf005 scarf005 merged commit 92d50db into cataclysmbnteam:main Mar 9, 2024
11 checks passed
@scarf005 scarf005 deleted the test-blocklist-no-hope branch March 9, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants