Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(balance): changes in perishables #4357

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

Lamandus
Copy link
Contributor

Purpose of change

This is an audit of perishable values. Some were using old ticks, some were too high to be considered perishable.

Describe the solution

Due to our standard season of 14 days, following changes were made:

  1. Any item with a spoilage over 60 days is now unperishable.
  2. Any item that used ticks for spoilage now use regular days/hour system.
  3. changed some items timers from d to days for standardization.

Describe alternatives you've considered

Testing

Additional context

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Mar 15, 2024
@github-actions github-actions bot added the tests changes related to tests label Mar 15, 2024
Copy link
Contributor

autofix-ci bot commented Mar 15, 2024

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@Lamandus Lamandus requested a review from chaosvolt March 15, 2024 08:57
@scarf005 scarf005 merged commit 18d7d65 into cataclysmbnteam:main Mar 15, 2024
12 checks passed
@Lamandus Lamandus deleted the unperish_extra branch April 10, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. tests changes related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants