Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI, port): Port hiding clothing from DDA #5732

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RobbieNeko
Copy link
Contributor

Checklist

Required

Optional

  • This PR ports commits from DDA or other cataclysm forks.
    • I have attributed original authors in the commit messages adding Co-Authored-By in the commit message.
    • I have linked the URL of original PR(s) in the description.

Purpose of change

Desired change by many, given how you might like the stats of an item but not want to actually see it on your character.

Describe the solution

Ports the feature from DDA CleverRaven/Cataclysm-DDA#52054

Describe alternatives you've considered

  • Wait for someone else to do it

Testing

Loaded in, figured out where it is. It works,
BUT
It currently has a visual bug regarding it printing the 'H' indicator on the wrong line. The correct item is still hidden.
Unsure of how to fix, hence the draft
image

Additional context

Help with figuring out how to fix the visual bug is appreciated

Small visual bug with where it is in the list, but otherwise good

Co-Authored-By: Fris0uman <[email protected]>
@github-actions github-actions bot added src changes related to source code. JSON related to game datas in JSON format. labels Nov 17, 2024
Copy link
Contributor

autofix-ci bot commented Nov 17, 2024

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@scarf005 scarf005 changed the title feat(content, port): Port hiding clothing from DDA feat(UI, port): Port hiding clothing from DDA Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant