Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use ancient legacy burst property with gatling shotgun #5734

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

chaosvolt
Copy link
Member

Checklist

Required

Optional

Purpose of change

Smol easy fix pointed out in the discord.

Describe the solution

Converted gatling shotgun to use the fire mode JSON all other select-fire guns use instead of the old-as-fuck burst property.

Describe alternatives you've considered

Removing it from the code entirely and making modders cry.

Testing

Used my fucking eyes.

Additional context

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 18, 2024
@RoyalFox2140
Copy link
Collaborator

Now it's orphaned. Idk what we want to do about that. It appears only one Kenan pack mod uses it, idk about independent mods.

https://github.com/search?q=repo%3AZlorthishen%2FBrightNights-Structured-Kenan-Modpack%20%22burst%22%3A%20&type=code

@chaosvolt chaosvolt merged commit 9f67a52 into cataclysmbnteam:main Nov 18, 2024
9 checks passed
@chaosvolt chaosvolt deleted the ez-bigun-fix branch November 18, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants