Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bandit issues #2381

Merged
merged 2 commits into from
Mar 11, 2023
Merged

Fix Bandit issues #2381

merged 2 commits into from
Mar 11, 2023

Conversation

jdangerx
Copy link
Member

For some reason, bandit on CI is calling us out for more SQL injection vulnerabilities than it is locally.

First, try to fix the things they caught. Second, we should try to figure out why the bandits differ.

@jdangerx
Copy link
Member Author

jdangerx commented Mar 10, 2023

Oh:
PyCQA/bandit#917 and PyCQA/bandit#915 were both merged into bandit 1.7.5 which was just released last night.

@jdangerx jdangerx requested review from a team and zaneselvans and removed request for a team March 10, 2023 19:57
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage: 50.0% and no project coverage change.

Comparison is base (7264ed5) 86.1% compared to head (d5a02f1) 86.1%.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2381   +/-   ##
=====================================
  Coverage   86.1%   86.1%           
=====================================
  Files         74      74           
  Lines       9376    9376           
=====================================
  Hits        8082    8082           
  Misses      1294    1294           
Impacted Files Coverage Δ
src/pudl/extract/ferc1.py 87.6% <ø> (ø)
src/pudl/helpers.py 87.4% <50.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@zaneselvans zaneselvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I thought the helpers.py had already been merged into dev? They look familiar.

@zaneselvans zaneselvans merged commit 8544f3e into dev Mar 11, 2023
@zaneselvans
Copy link
Member

I think the pre-commit hooks also only update once a week, and so they were still at bandit 1.7.4 while the new environment in CI immediately updated to 1.7.5 the next time it got rebuilt.

@jdangerx jdangerx deleted the daz/fix-bandit branch March 22, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants