Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Dashboard JS Shared Components #68

Open
mattporritt opened this issue Nov 14, 2020 · 1 comment
Open

Refactor Dashboard JS Shared Components #68

mattporritt opened this issue Nov 14, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mattporritt
Copy link

The quiz dashboard and in progress dashboard share several JS components. Currently these are replicated as methods in each dashboard module.
These methods should be refactored out into their own JS modules.

@mattporritt mattporritt added the enhancement New feature or request label Nov 14, 2020
@guillogo guillogo self-assigned this Mar 19, 2021
guillogo added a commit that referenced this issue Mar 22, 2021
guillogo added a commit that referenced this issue Mar 22, 2021
guillogo added a commit that referenced this issue Mar 22, 2021
guillogo added a commit that referenced this issue Mar 22, 2021
guillogo added a commit that referenced this issue Mar 24, 2021
guillogo added a commit that referenced this issue Mar 24, 2021
guillogo added a commit that referenced this issue Mar 24, 2021
guillogo added a commit that referenced this issue Mar 24, 2021
@guillogo
Copy link
Contributor

Hi @mattporritt ,

I've created these PRs to solve issue 68. Basically we have now 4 new JS modules that are called from all the dashboards and the student search. For the master branch I had to add a commit to fix unit test because there is a new deprecated function for PHPUnit 10.

Master: #101
Moodle 3.10: #100
Moodle 3.9: #99
Moodle 3.5: #102

(CI test for 35 is failing when try to install Moodle 3.6)

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants