Add parameters to exclude tables and columns #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
classes/helper.php
Outdated
| // Knowns tables to skip. | ||
| $skiptables = ['grade_grades_history']; | ||
| // Known tables to skip. | ||
| $skiptables = ['grade_grades_history', 'notifications', 'question_attempt_step_data']; |
There was a problem hiding this comment.
Lets turn this into a new command line option --exclude-tables so we don't hard code it and can more easily add more on the fly
I think grade_grades_history should always be skipped so leave it hard coded. It should be hard coded in core in db_should_replace but we can worry about that later
tuanngocnguyen
force-pushed
the
improvement
branch
4 times, most recently
from
94680a4
to
e376510
Compare
tuanngocnguyen
force-pushed
the
improvement
branch
from
e376510
to
cad0186
Compare
tuanngocnguyen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.