debug

catalystneuro · Aug 4, 2024 · adcf16e · adcf16e
1 parent c148125
commit adcf16e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/neuroconv/tools/aws/_submit_aws_batch_job.py b/src/neuroconv/tools/aws/_submit_aws_batch_job.py
@@ -426,8 +426,8 @@ def _ensure_job_definition_exists(
 
     job_definition_name = f"neuroconv_batch"
     job_definition_name += f"_{parsed_docker_image_name}-image"
-    job_definition_name += "_{minimum_worker_ram_in_gib}-GiB-RAM"
-    job_definition_name += "_{minimum_worker_cpus}-CPU"
+    job_definition_name += f"_{minimum_worker_ram_in_gib}-GiB-RAM"
+    job_definition_name += f"_{minimum_worker_cpus}-CPU"
     if docker_tag is None or docker_tag == "latest":
         date = datetime.now().strftime("%Y-%m-%d")
         job_definition_name += f"_created-on-{date}"

diff --git a/tests/test_minimal/test_tools/aws_tools.py b/tests/test_minimal/test_tools/aws_tools.py
@@ -12,6 +12,9 @@ def test_submit_aws_batch_job():
         command=command,
     )
 
+    # TODO: check job ID from boto3
+    # TODO: check status on table, should be 'Job submitted...'
+
 
 def test_submit_aws_batch_job_with_dependencies():
     job_name_1 = "test_submit_aws_batch_job_with_dependencies_1"
@@ -25,6 +28,9 @@ def test_submit_aws_batch_job_with_dependencies():
     )
     job_submission_info = info["job_submission_info"]
 
+    # TODO: check job ID from boto3
+    # TODO: check status on table, should be 'Job submitted...'
+
     job_name_2 = "test_submit_aws_batch_job_with_dependencies_1"
     command_2 = "echo 'Testing NeuroConv AWS Batch submission with dependencies."
     job_dependencies = [{"jobId": job_submission_info["jobId"], "type": "SEQUENTIAL"}]
@@ -34,3 +40,6 @@ def test_submit_aws_batch_job_with_dependencies():
         command=command_2,
         job_dependencies=job_dependencies,
     )
+
+    # TODO: check job ID from boto3
+    # TODO: check status on table, should be 'Job submitted...'