Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate unit_electrode_indices to SortingInterface #1124

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

h-mayorquin
Copy link
Collaborator

This will allow the user to pass a mapping between units and the electrodes on the electrode table. Eventually I will use this to add a more robust solution like here:

#1112 (comment)

@h-mayorquin h-mayorquin self-assigned this Nov 5, 2024
@h-mayorquin h-mayorquin marked this pull request as ready for review November 5, 2024 22:20
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.60%. Comparing base (419ab11) to head (ff41d1c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1124   +/-   ##
=======================================
  Coverage   90.59%   90.60%           
=======================================
  Files         129      129           
  Lines        8187     8193    +6     
=======================================
+ Hits         7417     7423    +6     
  Misses        770      770           
Flag Coverage Δ
unittests 90.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nterfaces/ecephys/basesortingextractorinterface.py 80.19% <100.00%> (+0.40%) ⬆️
src/neuroconv/nwbconverter.py 94.85% <ø> (ø)
...c/neuroconv/tools/spikeinterface/spikeinterface.py 91.15% <100.00%> (+0.06%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant