Quote variable dereference properly

catchorg · Nov 15, 2023 · 4d71b1e · 4d71b1e
1 parent 8676720
commit 4d71b1e
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/extras/CatchAddTests.cmake b/extras/CatchAddTests.cmake
@@ -132,7 +132,7 @@ function(catch_discover_tests_impl)
     endforeach(char)
     # ...add output dir
     if(output_dir)
-      string(REGEX REPLACE "[^A-Za-z0-9_]" "_" test_name_clean ${test_name})
+      string(REGEX REPLACE "[^A-Za-z0-9_]" "_" test_name_clean "${test_name}")
       set(output_dir_arg "--out ${output_dir}/${output_prefix}${test_name_clean}${output_suffix}")
     endif()
 
@@ -150,8 +150,7 @@ function(catch_discover_tests_impl)
       "${prefix}${test}${suffix}"
       PROPERTIES
       WORKING_DIRECTORY "${_TEST_WORKING_DIR}"
-      ${properties}
-    )
+      ${properties})
 
     if(environment_modifications)
       add_command(set_tests_properties