Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark CATCH_CONFIG_ options as advanced #2756

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

ChrisThrasher
Copy link
Collaborator

Description

These options are rather low-level and don't need to be seen in the CMake cache unless you opt into seeing all other advanced options.

This removes a lot of cache entries from the screen when using a GUI or TUI to view the cache thus making it easier for developers of Catch2 and users of it using FetchContent to focus on the cache variables they're most likely to change.

Before:
Screenshot 2023-10-31 at 10 20 16 AM

After:
Screenshot 2023-10-31 at 10 18 58 AM

These options are rather low-level and don't need to be seen in the
CMake cache unless you opt into seeing all other advanced options.

This removes a lot of cache entries from the screen when using a GUI
or TUI to view the cache thus making it easier for users to focus on
the cache variables they're more likely to change on a frequent
basis.
Copy link
Member

@horenmar horenmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sure.

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #2756 (bfb8eef) into devel (79d39a1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            devel    #2756   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files         190      190           
  Lines        7855     7855           
=======================================
  Hits         7176     7176           
  Misses        679      679           

@ChrisThrasher ChrisThrasher merged commit a8cf3e6 into devel Oct 31, 2023
146 checks passed
@ChrisThrasher ChrisThrasher deleted the advanced_config_options branch October 31, 2023 23:27
@horenmar horenmar added the Building and Packaging Issues affecting build/packaging scripts and utilities label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Building and Packaging Issues affecting build/packaging scripts and utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants