Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export: Add networkx 2 compatibility #27

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Export: Add networkx 2 compatibility #27

merged 1 commit into from
Nov 1, 2018

Conversation

clbarnes
Copy link
Collaborator

Includes some sightly gross setup.py mangling to force builds with both
nx1 and nx2.

Will break (in an informative way) if CATMAID upgrades to nx2.

@clbarnes clbarnes force-pushed the feature/26-nx2 branch 3 times, most recently from 1f3e989 to 37d5f24 Compare October 26, 2018 17:55
Includes some sightly gross setup.py mangling to force builds with both
nx1 and nx2.

Will break (in an informative way) if CATMAID upgrades to nx2.
@clbarnes
Copy link
Collaborator Author

To check:

  • Should I just shave all the complexity away by removing nx1 compatibility?

@aschampion aschampion self-requested a review November 1, 2018 17:47
Copy link
Contributor

@aschampion aschampion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nx1 complexity seems not too onerous at this point, so seems reasonable to keep around until CM upgrades.

@clbarnes clbarnes merged commit 5a5d93f into master Nov 1, 2018
@clbarnes clbarnes mentioned this pull request Nov 1, 2018
@clbarnes clbarnes deleted the feature/26-nx2 branch November 1, 2018 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants