Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement NameResolver application #28

Merged
merged 2 commits into from
Nov 1, 2018
Merged

Conversation

clbarnes
Copy link
Collaborator

@clbarnes clbarnes commented Oct 29, 2018

Catmaid client application which allows users to put in the string name/ title of an object and get back its database ID. Currently has implementations for users and stacks, but it's trivial to add more as they become useful.

Resolves #21.

PR is a bit noisy because I did some significant refactors (as the stable of CatmaidClientApplications is growing) and I blackened the files I touched.

The important changes are

  • catpy/applications/nameresolver.py
    • implementation (caches HTTP responses, ensures unique matches)
  • tests/test_nameresolver.py
    • tests
  • catpy/exceptions
    • collects exception classes for convenience

@aschampion
Copy link
Contributor

aschampion commented Nov 1, 2018

Since there's a lot of formatting changes around single-vs-double quotes and newlines, is there a style file that should be in the repo?

e: I suppose this is the point of #29

@clbarnes
Copy link
Collaborator Author

clbarnes commented Nov 1, 2018

Those are all added by black, or are added for consistency with it (prefer double outer quotes and single inner quotes in e.g. the setup.py requirements), which I intend to enforce at some point (#29 ). But that can come in its own feature branch.

When I do that, I'll add an entry to the CONTRIBUTING file.

@clbarnes clbarnes merged commit 474b667 into master Nov 1, 2018
@clbarnes clbarnes mentioned this pull request Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NameResolver class
2 participants