Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(whiskers)!: switch to tera, use rich context objects #150

Merged
merged 12 commits into from
Mar 31, 2024

Conversation

backwardspy
Copy link
Member

@backwardspy backwardspy commented Mar 30, 2024

BEGIN_COMMIT_OVERRIDE
feat!: switch to tera & rich context variables
feat(whiskers): enforce semver versioning in frontmatter
docs(whiskers): update examples to match tera syntax
END_COMMIT_OVERRIDE

@backwardspy backwardspy added enhancement New feature or request whiskers Issues relating to whiskers labels Mar 30, 2024
@backwardspy backwardspy self-assigned this Mar 30, 2024
@backwardspy backwardspy changed the title feat(whiskers)!: switch to tera, use rich context objects whiskers: switch to tera, use rich context objects Mar 30, 2024
whiskers/Cargo.toml Outdated Show resolved Hide resolved
whiskers/Cargo.toml Show resolved Hide resolved
whiskers/Cargo.toml Show resolved Hide resolved
whiskers/examples/demo/output/frappe.md Show resolved Hide resolved
whiskers/src/cli.rs Show resolved Hide resolved
whiskers/src/cli.rs Show resolved Hide resolved
whiskers/src/cli.rs Show resolved Hide resolved
Copy link
Contributor

@nullishamy nullishamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get this merged!

@sgoudham sgoudham marked this pull request as ready for review March 31, 2024 14:46
Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glanced over the PR, found no glaring issues and docs have been updated. Can't wait for this to be rolled out across the organisation.

Absolutely stellar work @backwardspy, and @nullishamy for the productive feedback.

@sgoudham sgoudham changed the title whiskers: switch to tera, use rich context objects feat(whiskers)!: switch to tera, use rich context objects Mar 31, 2024
@sgoudham sgoudham merged commit bdf0dc5 into main Mar 31, 2024
2 of 3 checks passed
@backwardspy backwardspy deleted the feat/terawhiskers branch March 31, 2024 14:53
sgoudham pushed a commit that referenced this pull request Jun 3, 2024
* feat(whiskers)!: rewrite from scratch with tera and rich context

* feat(whiskers): convert demo example to tera

* feat(whiskers): convert frontmatter example to tera

* feat(whiskers): convert simple single-file example to tera

* feat(whiskers): convert overrides example to tera

* docs(whiskers): update for 2.0

* docs(whiskers): update overrides section(s)

* chore(whiskers): add beta suffix to version number

* Revert "chore(whiskers): add beta suffix to version number"

This reverts commit 2d60034.

* feat(whiskers): bring back 0.6 opacity red in demo example

* docs(whiskers): document the --dry-run flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request whiskers Issues relating to whiskers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants