-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(whiskers): create needed parent directories by default #182
Conversation
i've been back and forth on this a bit, i agree for build tools it makes sense for this to just happen. i'll think about it some more.
is that done based on PR titles? i assumed it would look at commits instead. will change them now! edit: ah, but i screwed up the commit message when i squashed 😅 there's as good a reason as any to just title the PR with it too. point taken! |
https://github.com/catppuccin/toolbox/actions/runs/8858928452/job/24328133362#step:2:127 It's looking at the PRs, both at the title and text content, since you can override them retroactively with
You should be able to just add that into #179 and it will show up in the changelog the next time release-please runs on main. |
we discussed this a little further and concluded that it does make sense to just do this by default, especially as this change to create directories is pretty non-destructive. overwriting existing files would possibly be a different discussion, but we're already doing that without an associated flag. i've removed the cli flag entirely as i can't think of a reason to disable this behaviour. if one comes up, i think it should be rolled into the same change as the aforementioned overwriting of files. |
thanks for the review & discussion! |
BEGIN_COMMIT_OVERRIDE
feat(whiskers): create needed parent directories by default
END_COMMIT_OVERRIDE