Cache bucket name optional account #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npalm
requested changes
Aug 6, 2019
There was a problem hiding this comment.
@Glen-Moonpig thanks for creating the PR, some small comments.
npalm
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The IAM roles that we use for deployment require us to use certain resource name prefixes, along with the account ID and suffix this was pushing the cache bucket name over the 63 character limit imposed by AWS.
I have added an input variable to make the account ID in the bucket name optional as we did not require it, but wanted to maintain backwards compatibility for others.
Migrations required
NO
Verification
We have deployed the module to our environments.
Documentation
Please ensure you update the README in
_docs/README.md. The README.md in the root can be updated by running the scriptci/bin/autodocs.sh