fix: remove leading / from SSM parameter names in policy ARNs
#1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Kqirk! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
Kqirk
force-pushed
the
add-support-ssm-hierarchy
branch
from
ce09ee5
to
f9ea0dd
Compare
Kqirk
changed the title
Kqirk
changed the title
kayman-mk
changed the title
/ from SSM parameter names in policy ARNs
kayman-mk
approved these changes
Jul 22, 2024
kayman-mk
pushed a commit
that referenced
this pull request
Jul 24, 2024
🤖 I have created a release *beep* *boop* --- ## [7.9.0](7.8.0...7.9.0) (2024-07-22) ### Features * add support for configuring runner worker root device name ([#1140](#1140)) ([a1f8266](a1f8266)) ### Bug Fixes * increase timeout for EC2 termination lambda ([#1156](#1156)) ([2bf6d3d](2bf6d3d)) * remove leading `/` from SSM parameter names in policy ARNs ([#1146](#1146)) ([beea51d](beea51d)) * use existing Runner package for Amazon Linux 2023 as default ([#1155](#1155)) ([c001183](c001183)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using SSM parameter hierarchies (as described in https://docs.aws.amazon.com/systems-manager/latest/userguide/sysman-paramstore-hierarchies.html) results in an error. See #1128
Several workarounds exist, but using
trimprefixmakes them superfluous. Having a/as first character results in the above mentioned error.Verification
Checked the ARN of parameter
/test/test. It showed up asarn:aws:ssm:eu-central-1:123456789012:parameter/test/testin the console. So no//at first place.