Allow log retention configuration #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geota
force-pushed
the
allow_log_retention_configuration
branch
from
afc69ac
to
6d3e1da
Compare
|
@geota thanks for the PR. will check it in the next days |
npalm
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Destruction was failing for me due to the template trying to be generated AFTER the bucket had already been destroyed which caused it to fail.
I also needed to support configuring log retention on the cloudwatch log group so we dont have unlimited retention. I set it to zero deays which maps to unlimited IIRC. I wanted to set it to null and let the AWS resource handle the defaulting but the autodocs script breaks with null as a default even though this is supported in TF.
Migrations required
NO
Verification
Please mention the examples you have verified.
Documentation
Please ensure you update the README in
_docs/README.md. The README.md in the root can be updated by running the scriptci/bin/autodocs.sh