Make use of on-demand instances in docker-machine #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npalm
approved these changes
Nov 14, 2019
There was a problem hiding this comment.
@skorfmann Thanks looks all good. For further PR's could you also generate the docs again? See instruction in the PR template. For now all fine.
Sweet, thanks for the quick response. Will keep the doc part in mind for potential future PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are running into issues with certain instance types not being available on the spot instances market every now and then. In addition to this, we have scenarios where it's not acceptable that jobs could be killed due to AWS reclaming the spot instance, but where we still would benefit from having the autoscaling of docker-machine.
That's why we'd like to make requesting a spot instance optional.
Migrations required
NO