Configurable docker image for runner #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 I really need it too. |
|
@mkalmykov thx will check your PR in the next days |
|
@npalm Thank you for the response. We've noticed that we need one more item to be configurable. I will add the code tomorrow and notify you when PR is ready. |
mkalmykov
force-pushed
the
feature/configurable_docker_image
branch
5 times, most recently
from
762a22e
to
2790451
Compare
|
New release created, thanks for the contribution. See https://github.com/npalm/terraform-aws-gitlab-runner/releases/tag/1.8.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @npalm!
This PR introduces configurable docker image for runners.
In our case we need the ability to use custom images, because we work with private docker registries and need to configure credential helpers to perform pulls from them. To handle this, I've added the variable
runners_imagewith default valuedocker:18.03.1-ce. So without setting this variable everything should work as before.