Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make AWS policy statement IDs unique #503

Merged
merged 1 commit into from
Jul 20, 2022
Merged

fix: Make AWS policy statement IDs unique #503

merged 1 commit into from
Jul 20, 2022

Conversation

JulianCBC
Copy link
Contributor

Description

Somehow the lambda permissions in the "terminate-instances" module have identical statement IDs and somehow this was fine until I tried to migrate my runner infrastructure to a different Terraform configuration.

Migrations required

No migrations required.

Verification

This has been verified on my production environment, which is a slightly tweaked version of the "runner-docker" example.

@kayman-mk
Copy link
Collaborator

Supported and looks good to me. StatementIds should be unique (see https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lambda_permission).

LGTM

npalm
npalm approved these changes Jun 20, 2022
View reviewed changes
Copy link
Collaborator

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JulianCBC thx LGTM

@npalm npalm changed the title Make statement IDs unique fix: Make AWS policy statement IDs unique Jul 16, 2022
@npalm npalm merged commit 05055c0 into cattle-ops:develop Jul 20, 2022
semantic-releaser bot pushed a commit that referenced this pull request Jul 20, 2022
@semantic-release-bot
chore(release): 5.1.0 [skip ci]
8a7049a 
## [5.1.0](5.0.2...5.1.0) (2022-07-20)

### Features

* add `clone_url` to `config.toml` ([#516](#516)) ([9a41525](9a41525))
* Tag aws_cloudwatch_event_rule resource + linting ([#519](#519)) ([f2e98bb](f2e98bb))

### Bug Fixes

* Make statement IDs unique ([#503](#503)) ([05055c0](05055c0))
@semantic-releaser
Copy link
Contributor

🎉 This PR is included in version 5.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@JulianCBC JulianCBC deleted the unique-stmtid-term-instances branch March 2, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npalm npalm npalm approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JulianCBC @kayman-mk @npalm