Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extra_hosts to config.toml #547

Merged
merged 5 commits into from
Oct 9, 2022
Merged

Conversation

veshant
Copy link
Contributor

@veshant veshant commented Sep 27, 2022

Description

Adds the missing parameter clone_url to the config.toml of the runner. In case the default clone URL from the GitLab project is not accessible from the runner's infrastructure (e.g. private DNS), the clone_url can be used to specify a different one (e.g. replace the private DNS entry by a public IP address).

Check the configuration docs for the runner.

Migrations required

NO

Verification

Deploy infrastructure with extra_hosts. Check that the runner can register and config.toml shows the extra_hosts. Runners communicate using updated hosts records.

@npalm npalm self-requested a review October 9, 2022 12:47
@npalm
Copy link
Collaborator

npalm commented Oct 9, 2022

Thanks!

@npalm npalm merged commit 1491698 into cattle-ops:develop Oct 9, 2022
semantic-releaser bot pushed a commit that referenced this pull request Oct 9, 2022
## [5.3.0](5.2.2...5.3.0) (2022-10-09)

### Features

* add extra_hosts to config.toml ([#547](#547)) ([1491698](1491698))

### Bug Fixes

* do not add the cache access policy if there is none ([#540](#540)) ([f69c8bb](f69c8bb))
* Too long host names for docker machines ([#549](#549)) ([2fc8e77](2fc8e77))
@semantic-releaser
Copy link
Contributor

🎉 This PR is included in version 5.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants