Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: detail the usage of S3 cache policy #614

Merged
merged 8 commits into from
Dec 31, 2022

Conversation

kayman-mk
Copy link
Collaborator

Description

As explained in #410 and #426 additional documentation is needed for

  • permissions needed to access the S3 cache. This is configured on the Runner instance and not on the Executor (as I thought too). But the documentation tolds a different story.

Migrations required

No

Verification

Just some comments. No verification done.

@kayman-mk
Copy link
Collaborator Author

This is a copy of #427 which was merged by accident into the develop branch.

@npalm Please approve.

@kayman-mk
Copy link
Collaborator Author

Failing workflow is tackled in #604

@npalm
Copy link
Collaborator

npalm commented Dec 31, 2022

Can you you shortly explain why pre_install and post_intall are not working for you? With those variables you can inject already scripts in the before and after installation.

@npalm npalm merged commit ef23286 into cattle-ops:main Dec 31, 2022
@kayman-mk kayman-mk deleted the kayma/code-docs branch January 3, 2023 10:05
@kayman-mk
Copy link
Collaborator Author

Can you you shortly explain why pre_install and post_intall are not working for you? With those variables you can inject already scripts in the before and after installation.

@npalm I didn't get the point here as a single comment was added only. Is this the right PR for the comment? If so, could you please give some more information please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants