Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching in the InspectorFloret might show fewer records than actually available #145

Closed
brototyp opened this issue Feb 18, 2019 · 1 comment
Closed

Searching in the InspectorFloret might show fewer records than actually available #145

brototyp opened this issue Feb 18, 2019 · 1 comment
Assignees
@Shukuyen
Labels
floret:inspector The Inspector Floret

Comments

@brototyp
Copy link
Member

Reproduction:

  • Go to the InspectorViewController
  • Search for something that matches only a few of the first items, but additional items further back in the list

Expected Behavior:

  • When the list is reduced to only match a few items more items are loaded from the storage

Observer Behavior:

  • While filtering only the currently loaded records are filtered
  • Additional items are only loaded once the user scrolls in the tableview
@brototyp brototyp added the floret:inspector The Inspector Floret label Feb 18, 2019
@Shukuyen Shukuyen self-assigned this Feb 18, 2019
Shukuyen added a commit that referenced this issue Mar 2, 2019
@Shukuyen
#145 fixed issue where searching in inspector floret would not instan…
7d5ee29 
…tly load additional records
Shukuyen added a commit that referenced this issue Mar 2, 2019
@Shukuyen
#145 fixed wrong guess of PR number
ea48f07
Shukuyen added a commit that referenced this issue Mar 3, 2019
@Shukuyen
#145 changed loadAdditionalRecords in inspector floret to only load n…
e617a38 
…ew records if the scrollview is at the bottom
brototyp added a commit that referenced this issue Mar 3, 2019
@brototyp
Merge pull request #161 from cauliframework/bugfix/145-load-additiona…
2b0557d 
…l-matching-items-after-search

#145 fixed issue where searching in inspector floret would not instan…
@brototyp
Copy link
Member Author

brototyp commented Mar 3, 2019

This got fixed in #161

@brototyp brototyp closed this as completed Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shukuyen Shukuyen

Labels
floret:inspector The Inspector Floret
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brototyp @Shukuyen