Add uri_parser method for RFC2396 compatibility
#398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiskoza
approved these changes
Aug 31, 2024
This commit introduces a new method `Axlsx#uri_parser` to handle URI parsing in a way that's compatible with both newer and older versions of Ruby's URI library. It checks for the presence of `URI::RFC2396_PARSER` and falls back to `URI::DEFAULT_PARSER` if not available, ensuring consistent behavior across different Ruby versions. Close caxlsx#397 Ref: ruby/uri#114
tagliala
force-pushed
the
chore/397-fix-parser-deprecation
branch
from
86b9ec1
to
4bc15ef
Compare
|
Done. This can be improved by extracting the regexp to a constant. However, since drawing is required before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit introduces a new method
Axlsx#uri_parserto handle URI parsing in a way that's compatible with both newer and older versions of Ruby's URI library. It checks for the presence ofURI::RFC2396_PARSERand falls back toURI::DEFAULT_PARSERif not available, ensuring consistent behavior across different Ruby versions.Close #397
Ref: ruby/uri#114
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.