Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WISH: Update binReadCounts() to read in chunks by default #101

Open
1 of 2 tasks
HenrikBengtsson opened this issue Nov 25, 2021 · 0 comments
Open
1 of 2 tasks

WISH: Update binReadCounts() to read in chunks by default #101

HenrikBengtsson opened this issue Nov 25, 2021 · 0 comments
Milestone

Comments

@HenrikBengtsson
Copy link
Collaborator

HenrikBengtsson commented Nov 25, 2021

Maybe we should update binReadCounts() to read in chunks by default. This should lower the risk for users running into hard-to-troubleshoot memory issues, e.g. #100.

Suggestion

  • Set a default value for argument chunkSize, e.g. chunkSize = 10e6
  • Until future.apply 1.9.0 is on CRAN, add a run-time check for future (>= 1.22.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant