Fix CI issues with Python version #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfsnow
changed the title
distutils)
Codecov Report
@@ Coverage Diff @@
## main #17 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 12 12
Lines 478 478
=======================================
Hits 472 472
Misses 6 6 |
dfsnow
commented
Oct 27, 2023
| @@ -12,7 +12,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - name: Checkout | |||
| uses: actions/checkout@v3 | |||
| uses: actions/checkout@v4 | |||
There was a problem hiding this comment.
Bumping these other Action versions because why not.
dfsnow
commented
Oct 27, 2023
| @@ -17,7 +17,7 @@ jobs: | |||
| - name: Setup python | |||
| uses: actions/setup-python@v4 | |||
| with: | |||
| python-version: 3.x | |||
There was a problem hiding this comment.
This line is the main culprit here, as this will now install 3.12 by default.
Version locking this to 3.11 works for now, but we should eventually update this and add 3.12 to the test matrix once wheels are available.
dfsnow
commented
Oct 27, 2023
Comment on lines
+1
to
+3
| numpy==1.26.* | ||
| pandas==2.* | ||
| pyarrow==13.0.* |
There was a problem hiding this comment.
Bumping these to any minor version. We'll need to manually bump some of them to get the correct wheels for 3.12.
|
Much appreciated |
wrridgeway
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes CI issues uncovered by #16.
Took me awhile to debug, but the
setup-pythonGitHub Action switched to using3.12in this most recent PR (since we didn't have the setup action version locked). Unfortunately, most of the package dependencies we're using do not yet have3.12wheels on PyPI. This resulted in build failures from trying to build from source while lacking system dependencies.