Add integer overflow check #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OuyangHang33
force-pushed
the
i71
branch
5 times, most recently
from
9fc1348
to
37c90ed
Compare
jyao1
reviewed
Apr 9, 2024
spdmlib/src/crypto/x509v3.rs
Outdated
| let (payload_length, bytes_consumed) = check_length(&data[index + 1..])?; | ||
| if index + 1 + bytes_consumed + payload_length > len { |
There was a problem hiding this comment.
to avoid overflow, the best way is to use minus. if bytes_consumed + payload_length > len - (index + 1)
There was a problem hiding this comment.
Got it. I have changed it with minus.
OuyangHang33
force-pushed
the
i71
branch
2 times, most recently
from
155ad2c
to
533c58a
Compare
Signed-off-by: OuyangHang33 <[email protected]>
|
Looks good to me. The fuzz test of nearly 20 hours was run. No issue found. |
jyao1
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #71