Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FMDB.podspec #806

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Update FMDB.podspec #806

merged 1 commit into from
Nov 30, 2020

Conversation

jamesstout
Copy link
Contributor

added osx.deployment_target = '10.11'

added osx.deployment_target  = '10.11'
@Kaspik
Copy link

Kaspik commented Nov 30, 2020

@ccgus Based on #743 we think minimum deployment target of this project is 10.11. But this required value is not mentioned in podspec. This results to all clients implementing post_install hook (see CocoaPods/CocoaPods#10070 and CocoaPods/CocoaPods#9884).

Please take a look and merge in, thank you! :)

@ccgus ccgus merged commit 3e5efdf into ccgus:master Nov 30, 2020
@ccgus
Copy link
Owner

ccgus commented Nov 30, 2020

Thanks! (I don't use CocoaPods, but this looks reasonable so I'm merging)

@Kaspik
Copy link

Kaspik commented Nov 30, 2020

@ccgus Thanks!

On similar note, your SPM Package.swift is missing completely the same :)

platforms: [
        .macOS(.v10_11),
    ],

https://docs.swift.org/package-manager/PackageDescription/PackageDescription.html

@jamesstout jamesstout deleted the update_podspec branch November 30, 2020 19:35
@jamesstout
Copy link
Contributor Author

Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants