Remove Lens-specific code from visualize

src/legacy/core_plugins/kibana/public/visualize/wizard/type_selection/new_vis_help.test.tsx

@@ -0,0 +1,76 @@
+/*
+ * Licensed to Elasticsearch B.V. under one or more contributor
+ * license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright
+ * ownership. Elasticsearch B.V. licenses this file to you under
+ * the Apache License, Version 2.0 (the "License"); you may
+ * not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React from 'react';
+import { shallowWithIntl } from 'test_utils/enzyme_helpers';
+import { NewVisHelp } from './new_vis_help';
+import chrome from 'ui/chrome';
+
+jest.doMock('ui/chrome');
+
+describe('NewVisHelp', () => {
+  it('should render as expected', () => {
+    (chrome.addBasePath as unknown) = (url: string) => `testbasepath${url}`;
+
+    expect(
+      shallowWithIntl(
+        <NewVisHelp
+          promotedTypes={[
+            {
+              aliasUrl: '/my/fancy/new/thing',
+              description: 'Some desc',
+              highlighted: false,
+              icon: 'wahtever',
+              name: 'whatever',
+              promotion: {
+                calloutText: 'Do it now!',
+                description: 'Look at this fancy new thing!!!',
+              },
+              title: 'Test title',
+            },
+          ]}
+        />
+      )
+    ).toMatchInlineSnapshot(`
+      <EuiText>
+        <p>
+          <FormattedMessage
+            defaultMessage="Start creating your visualization by selecting a type for that visualization."
+            id="kbn.visualize.newVisWizard.helpText"
+            values={Object {}}
+          />
+        </p>
+        <p>
+          <strong>
+            Look at this fancy new thing!!!
+          </strong>
+        </p>
+        <EuiButton
+          fill={true}
+          href="testbasepath/my/fancy/new/thing"
+          iconSide="right"
+          iconType="popout"
+          size="s"
+        >
+          Do it now!
+        </EuiButton>
+      </EuiText>
+    `);
+  });
+});

src/legacy/core_plugins/kibana/public/visualize/wizard/type_selection/new_vis_help.tsx

@@ -19,27 +19,39 @@
 
 import { FormattedMessage } from '@kbn/i18n/react';
 import React from 'react';
-
 import { EuiText, EuiButton } from '@elastic/eui';
+import chrome from 'ui/chrome';
+import { VisTypeAliasListEntry } from './type_selection';
+
+interface Props {
+  promotedTypes: VisTypeAliasListEntry[];
+}
 
-export const NewVisHelp = () => (
-  <EuiText>
-    <p>
-      <FormattedMessage
-        id="kbn.visualize.newVisWizard.helpText"
-        defaultMessage="Start creating your visualization by selecting a type for that visualization."
-      />
-    </p>
-    <p>
-      <strong>
+export function NewVisHelp(props: Props) {
+  return (
+    <EuiText>
+      <p>
         <FormattedMessage
-          id="kbn.visualize.newVisWizard.tryLensText"
-          defaultMessage="Try Lens, our new, intuitive way to create visualizations."
+          id="kbn.visualize.newVisWizard.helpText"
+          defaultMessage="Start creating your visualization by selecting a type for that visualization."
         />
-      </strong>
-    </p>
-    <EuiButton fill size="s" iconType="popout" iconSide="right">
-      Go to Lens
-    </EuiButton>
-  </EuiText>
-);
+      </p>
+      {props.promotedTypes.map(t => (
+        <>
+          <p>
+            <strong>{t.promotion!.description}</strong>
+          </p>
+          <EuiButton
+            href={chrome.addBasePath(t.aliasUrl)}
+            fill
+            size="s"
+            iconType="popout"
+            iconSide="right"
+          >
+            {t.promotion!.calloutText}
+          </EuiButton>
+        </>
+      ))}
+    </EuiText>
+  );
+}

src/legacy/core_plugins/kibana/public/visualize/wizard/type_selection/type_selection.tsx

@@ -43,11 +43,11 @@ import { VisHelpText } from './vis_help_text';
 import { VisTypeIcon } from './vis_type_icon';
 import { TypesStart } from '../../../../../visualizations/public/np_ready/types';
 
-interface VisTypeListEntry extends VisType {
+export interface VisTypeListEntry extends VisType {
   highlighted: boolean;
 }
 
-interface VisTypeAliasListEntry extends VisTypeAlias {
+export interface VisTypeAliasListEntry extends VisTypeAlias {
   highlighted: boolean;
 }
 
@@ -152,7 +152,9 @@ class TypeSelection extends React.Component<TypeSelectionProps, TypeSelectionSta
                     </h2>
                   </EuiTitle>
                   <EuiSpacer size="m" />
-                  <NewVisHelp />
+                  <NewVisHelp
+                    promotedTypes={(visTypes as VisTypeAliasListEntry[]).filter(t => t.promotion)}
+                  />
                 </React.Fragment>
               )}
             </EuiFlexItem>
@@ -196,7 +198,7 @@ class TypeSelection extends React.Component<TypeSelectionProps, TypeSelectionSta
       });
     }
 
-    return sortByOrder(entries, ['highlighted', 'isPromoted', 'title'], ['desc', 'asc', 'asc']);
+    return sortByOrder(entries, ['highlighted', 'promotion', 'title'], ['desc', 'asc', 'asc']);
   }
 
   private renderVisType = (visType: VisTypeListEntry | VisTypeAliasListEntry) => {

src/legacy/core_plugins/visualizations/public/np_ready/types/vis_type_alias_registry.ts

@@ -37,12 +37,17 @@ interface VisualizationsAppExtension {
   }) => VisualizationListItem;
 }
 
+export interface VisTypeAliasPromotion {
+  description: string;
+  calloutText: string;
+}
+
 export interface VisTypeAlias {
   aliasUrl: string;
   name: string;
   title: string;
   icon: string;
-  isPromoted?: boolean;
+  promotion?: VisTypeAliasPromotion;
   description: string;
 
   appExtensions?: {

x-pack/legacy/plugins/lens/public/help_menu_util.tsx

@@ -0,0 +1,48 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import React from 'react';
+import { EuiHorizontalRule, EuiSpacer, EuiLink, EuiText, EuiIcon, EuiButton } from '@elastic/eui';
+import { ELASTIC_WEBSITE_URL, DOC_LINK_VERSION } from 'ui/documentation_links';
+import { i18n } from '@kbn/i18n';
+import { FormattedMessage } from '@kbn/i18n/react';
+import { render, unmountComponentAtNode } from 'react-dom';
+import { Chrome } from 'ui/chrome';
+
+export function addHelpMenuToAppChrome(chrome: Chrome) {
+  chrome.helpExtension.set(domElement => {
+    render(<HelpMenu />, domElement);
+    return () => {
+      unmountComponentAtNode(domElement);
+    };
+  });
+}
+
+function HelpMenu() {
+  return (
+    <>
+      <EuiHorizontalRule margin="none" />
+      <EuiSpacer />
+      <EuiButton
+        fill
+        iconType="popout"
+        href={`${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/lens.html`}
+        target="_blank"
+      >
+        <FormattedMessage id="xpack.lens.helpMenu.docLabel" defaultMessage="Lens documentation" />
+      </EuiButton>
+      <EuiSpacer />
+      <EuiText size="s">
+        <EuiIcon type="logoGithub" color="primary" /> &nbsp;
+        <EuiLink href="https://github.com/elastic/kibana/issues/new" target="_blank">
+          {i18n.translate('xpack.lens.helpMenu.feedbackLinkText', {
+            defaultMessage: 'Provide feedback for the Lens application',
+          })}
+        </EuiLink>
+      </EuiText>
+    </>
+  );
+}

x-pack/legacy/plugins/lens/public/index.ts

@@ -20,6 +20,7 @@ import { IScope } from 'angular';
 import chrome from 'ui/chrome';
 import { appStart, appSetup, appStop } from './app_plugin';
 import { PLUGIN_ID } from '../common';
+import { addHelpMenuToAppChrome } from './help_menu_util';
 
 // TODO: Convert this to the "new platform" way of doing UI
 function Root($scope: IScope, $element: JQLite) {
@@ -30,6 +31,8 @@ function Root($scope: IScope, $element: JQLite) {
   });
 
   appSetup();
+  addHelpMenuToAppChrome(chrome);
+
   return render(appStart(), el);
 }
 

x-pack/legacy/plugins/lens/public/register_vis_type_alias.ts

@@ -11,7 +11,14 @@ import { BASE_APP_URL, getEditPath } from '../common';
 visualizations.types.registerAlias({
   aliasUrl: BASE_APP_URL,
   name: 'lens',
-  isPromoted: true,
+  promotion: {
+    description: i18n.translate('xpack.lens.visTypeAlias.promotion.description', {
+      defaultMessage: 'Try Lens, our new, intuitive way to create visualizations.',
+    }),
+    calloutText: i18n.translate('xpack.lens.visTypeAlias.promotion.calloutText', {
+      defaultMessage: 'Go to Lens',
+    }),
+  },
   title: i18n.translate('xpack.lens.visTypeAlias.title', {
     defaultMessage: 'Lens Visualizations',
   }),