ImageSequence slicing: handle negative offset #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #485 +/- ##
==========================================
+ Coverage 40.59% 40.63% +0.03%
==========================================
Files 177 177
Lines 15549 15550 +1
Branches 2776 2776
==========================================
+ Hits 6312 6318 +6
+ Misses 8697 8691 -6
- Partials 540 541 +1 |
|
If there are no objections, I'll merge as soon as tests pass since it seems at least a couple users are already having problems with this bug. |
|
Sounds good to me, as all tests pass - and the new test is very welcome 👍 |
ndevenish
pushed a commit
that referenced
this pull request
Jul 26, 2023
Without this, slices sometimes needed to be indexed by their original image index, even inside the slice. The previous workaround in 67aab2 (#485) for negative offset was reacting to the erroneous behaviour introduced by including batch offsets in imagesequence slicing.
toastisme
pushed a commit
to toastisme/dxtbx
that referenced
this pull request
Jul 18, 2024
Without this, slices sometimes needed to be indexed by their original image index, even inside the slice. The previous workaround in 67aab2 (cctbx#485) for negative offset was reacting to the erroneous behaviour introduced by including batch offsets in imagesequence slicing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close dials/dials#2011. Added a test to catch the regression described there, but please see if there's anything else you'd like to test about ImageSequences with offset -1 (i.e. anything starting from image 0?)
@graeme-winter who shall I ask to review?