🐛 std::rand replaced by std::mt19937_64 (#124)

* 🐛 std::rand replaced by std::mt19937_64 * 🎨 ClangFormat changes Signed-off-by: ClangFormat <[email protected]> --------- Signed-off-by: ClangFormat <[email protected]> Co-authored-by: Drewniok <[email protected]> Co-authored-by: ClangFormat <[email protected]>
cda-tum · Feb 12, 2023 · 49c183e · 49c183e
1 parent b5df6f3
commit 49c183e
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/include/fiction/technology/charge_distribution_surface.hpp b/include/fiction/technology/charge_distribution_surface.hpp
@@ -758,13 +758,10 @@ class charge_distribution_surface<Lyt, false> : public Lyt
 
         if (!candidates.empty())
         {
-            const auto random_index =
-                static_cast<uint64_t>(std::rand()) %  // NOLINT: we use rand() due to its performance advantage; we do
-                                                      // not need cryptographic security here
-                candidates.size();
-
-            const auto random_element         = index_vector[candidates[random_index]];
-            strg->cell_charge[random_element] = sidb_charge_state::NEGATIVE;
+            static std::mt19937_64                  generator(std::random_device{}());
+            std::uniform_int_distribution<uint64_t> dist(0, candidates.size() - 1);
+            const auto                              random_element = index_vector[candidates[dist(generator)]];
+            strg->cell_charge[random_element]                      = sidb_charge_state::NEGATIVE;
             negative_indices.push_back(random_element);
 
             strg->system_energy += -(this->get_local_potential_by_index(random_element).value());