Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed a bug in SAT-based graph coloring #100

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Conversation

marcelwa
Copy link
Collaborator

This bug occurred when clique information was provided for mutex cliques of the same size. The SAT solver would then not be able to find a proper coloring anymore and the attempt would fail.

Many thanks to @simon1hofmann for reporting!

…nformation was provided for mutex cliques of the same size
@marcelwa marcelwa added the bug Something isn't working label Jan 27, 2023
@marcelwa marcelwa self-assigned this Jan 27, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #100 (5959cdc) into main (2967cd0) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   93.63%   93.67%   +0.03%     
==========================================
  Files          58       58              
  Lines        6083     6087       +4     
==========================================
+ Hits         5696     5702       +6     
+ Misses        387      385       -2     
Impacted Files Coverage Δ
...nclude/fiction/algorithms/graph/graph_coloring.hpp 96.34% <100.00%> (+0.04%) ⬆️
...ction/algorithms/physical_design/color_routing.hpp 95.65% <0.00%> (+2.17%) ⬆️
include/fiction/utils/stl_utils.hpp 100.00% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2967cd0...5959cdc. Read the comment docs.

@marcelwa marcelwa merged commit 4575192 into main Jan 27, 2023
@marcelwa marcelwa deleted the graph-coloring-fix branch January 27, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant