Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed a bug in SAT-based graph coloring (this time for real) #101

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

marcelwa
Copy link
Collaborator

The bug occurred when clique information was provided for mutex cliques. The algorithm now falls back to MCS coloring.

…nformation was provided for mutex cliques of the same size (this time for real)
@marcelwa marcelwa added the bug Something isn't working label Jan 30, 2023
@marcelwa marcelwa self-assigned this Jan 30, 2023
@marcelwa marcelwa enabled auto-merge (squash) January 30, 2023 11:17
@marcelwa
Copy link
Collaborator Author

Again, many thanks to @simon1hofmann for reporting!

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #101 (783293c) into main (4575192) will increase coverage by 0.00%.
The diff coverage is 94.11%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   93.67%   93.68%           
=======================================
  Files          58       58           
  Lines        6087     6095    +8     
=======================================
+ Hits         5702     5710    +8     
  Misses        385      385           
Impacted Files Coverage Δ
...nclude/fiction/algorithms/graph/graph_coloring.hpp 96.44% <94.11%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4575192...783293c. Read the comment docs.

@marcelwa marcelwa merged commit 3cb0b99 into main Jan 30, 2023
@marcelwa marcelwa deleted the graph-coloring-fix branch January 30, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant