✨ Added a framework to represent and handle SiDB defects #103

marcelwa · 2023-01-30T12:55:56Z

No description provided.

…-Si(100) surface

…ration)

…yout

…by any defect

… as SiDB surface defects

…gers

…e types on certain tiles

…ilation error that would occur on compilers other than GCC

…libraries as well as a function that utilizes this information and maps it against an SiDB surface to blacklist tiles

…lysis, and the new get_functional_implementations interface of gate libraries

…lus values for electrical charge, electric permittivity, and Thomas-Fermi screening distance

…emory. This should fix out-of-memory errors and consequently failed compilations

…es and dot indices

…t types if implemented by the layout

…ng of coulomb values

… <coulomb> tag for uncharged defects

…istency with exact

Signed-off-by: ClangFormat <[email protected]>

codecov · 2023-01-30T15:49:33Z

Codecov Report

Merging #103 (1dc2a34) into main (863b5f4) will increase coverage by 0.27%.
The diff coverage is 98.35%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   93.88%   94.16%   +0.27%     
==========================================
  Files          58       65       +7     
  Lines        6099     6477     +378     
==========================================
+ Hits         5726     6099     +373     
- Misses        373      378       +5

Impacted Files	Coverage Δ
include/fiction/algorithms/path_finding/a_star.hpp	`97.53% <ø> (ø)`
...tion/algorithms/path_finding/jump_point_search.hpp	`98.42% <ø> (ø)`
...properties/critical_path_length_and_throughput.hpp	`92.59% <ø> (ø)`
include/fiction/io/read_fqca_layout.hpp	`98.68% <ø> (ø)`
include/fiction/layouts/clocking_scheme.hpp	`97.22% <ø> (ø)`
include/fiction/layouts/gate_level_layout.hpp	`99.77% <ø> (ø)`
include/fiction/layouts/obstruction_layout.hpp	`100.00% <ø> (ø)`
include/fiction/technology/cell_ports.hpp	`100.00% <ø> (ø)`
include/fiction/technology/fcn_gate_library.hpp	`88.09% <ø> (ø)`
...ude/fiction/technology/inml_topolinano_library.hpp	`89.52% <ø> (ø)`
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 863b5f4...1dc2a34. Read the comment docs.

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 27. Check the log or trigger a new build to see more.

include/fiction/io/read_sqd_layout.hpp

include/fiction/technology/sidb_defects.hpp

include/fiction/utils/truth_table_utils.hpp

github-actions

clang-tidy made some suggestions

test/technology/sidb_surface_analysis.cpp

github-actions

clang-tidy made some suggestions

include/fiction/io/read_sqd_layout.hpp

github-actions

clang-tidy made some suggestions

include/fiction/technology/sidb_defects.hpp

include/fiction/utils/truth_table_utils.hpp

# Conflicts: # include/fiction/io/write_qll_layout.hpp

…ilable

marcelwa and others added 30 commits March 7, 2022 17:16

feat: Added data structures to represent fabrication defects on the H…

7e924d0

…-Si(100) surface

Distinction between charged and uncharged defects

cc2e125

Spacing values and RST documentation

bc81d4b

docs: Fixed doxygenenum directive (does not support the 'members' ope…

b1c7497

…ration)

Added a function to compute the extent of single SiDB defects in a la…

e809358

…yout

Added a function to compute all SiDBs on a surface that are affected …

8269472

…by any defect

feat: Added a simple parser to read printed Python arrays of integers…

d5ad572

… as SiDB surface defects

fix: Variable assignment fix under Windows

e4963b2

fix: Underflow in for loop with negative values

307e184

fix: Changed data types for loop variables

042c616

fix: Windows underflow issue while comparing signed and unsigned inte…

1c99e03

…gers

feat: Added a blacklisting mechanism for exact to disable certain gat…

4f48a08

…e types on certain tiles

fix: 'reference to local binding declared in enclosing function' comp…

14eaa6f

…ilation error that would occur on compilers other than GCC

feat: Added an interface to extract functional information from gate …

56e3ac3

…libraries as well as a function that utilizes this information and maps it against an SiDB surface to blacklist tiles

docs: Added RST documentation for truth table utils, SiDB surface ana…

895f48e

…lysis, and the new get_functional_implementations interface of gate libraries

✨ Added SiDB defect support to the SQD writer

5b19158

Changed the defects layer specification with respect to Samuel's input

0e89425

🏷️ Added an sidb_defect type that encapsulates the sidb_defect_type p…

06372b1

…lus values for electrical charge, electric permittivity, and Thomas-Fermi screening distance

💚 Switched to single-threaded build for Coverage CI to consume less m…

c91845f

…emory. This should fix out-of-memory errors and consequently failed compilations

💚 Fixed Window's "unexpected token 'attribute specifier'" error

564dcb4

➕ Added tinyXML2 as a submodule

5207818

✨ Added an SQD file reader to parse SiDB layouts

ecc7d8a

✅ Added an SQD file reader tests to check for parsing errors

86b238d

✅ Added more SQD file reader tests to check for valid dimer coordinat…

5296a7d

…es and dot indices

🎨 Simplified bounding box implementation

4612605

✨ Adjusted write_sqd_layout and read_sqd_layout to process SiDB defec…

8abc64a

…t types if implemented by the layout

✅ Updated a test case for the SQD reader to validate the proper parsi…

aaa935f

…ng of coulomb values

✅ Added a test file for the SQD writer that incorporates the SQD reader

e0fe1e0

📝 Reflect SQD reader/writer changes in documentation

e2be547

🎨 Adjust sqd file writer with respect to Samuel's feedback: leave out…

988cd4d

… <coulomb> tag for uncharged defects

🎨 Consistency fix

26d17ba

marcelwa added the enhancement New feature or request label Jan 30, 2023

marcelwa self-assigned this Jan 30, 2023

marcelwa and others added 12 commits January 30, 2023 14:30

🎨 Split the upper_bound parameter into an x and y coordinate for cons…

0f8d395

…istency with exact

🔥 Removed design files

1070cc8

🐛 Fixed tinyxml2 header positioning

2f12951

🚚 Renamed script to better express its purpose

5877474

📝 Added missing documentation for input parsing functions

3ceab45

🎨 Fixed missing includes

11cbe2a

🎨 ClangFormat changes

704448d

Signed-off-by: ClangFormat <[email protected]>

📝 Added missing documentation on file writers

1265d00

🎨 Fixed missing phmap in clang-format

116d830

🎨 Moved from std::set to std::unordered_set

c629dde

🔀 Merge

047049c

📝 Fixed documentation

3c59356

github-actions bot reviewed Jan 30, 2023

View reviewed changes

test/technology/sidb_surface_analysis.cpp Outdated Show resolved Hide resolved

test/technology/sidb_surface_analysis.cpp Outdated Show resolved Hide resolved

github-actions bot reviewed Jan 30, 2023

View reviewed changes

include/fiction/io/read_sqd_layout.hpp Outdated Show resolved Hide resolved

🎨 Addressed clang-tidy's comments

cf867c5

github-actions bot reviewed Jan 30, 2023

View reviewed changes

include/fiction/technology/sidb_defects.hpp Show resolved Hide resolved

include/fiction/utils/truth_table_utils.hpp Show resolved Hide resolved

include/fiction/utils/truth_table_utils.hpp Outdated Show resolved Hide resolved

marcelwa added 7 commits January 30, 2023 19:08

🎨 Addressed further clang-tidy comments

0da9428

💚 Fixed a build issue

ed03a15

Merge branch 'main' into sidb_defects

c6429ca

Merge branch 'main' into sidb_defects

bb2ab53

# Conflicts: # include/fiction/io/write_qll_layout.hpp

⚗️ Updated experiment script

8a45486

⚗️ Provide fall-back experiment implementations in case Z3 is not ava…

f26ec51

…ilable

🔀 Merge

1dc2a34

marcelwa merged commit 70d6a91 into main Jan 31, 2023

marcelwa deleted the sidb_defects branch January 31, 2023 19:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Added a framework to represent and handle SiDB defects #103

✨ Added a framework to represent and handle SiDB defects #103

marcelwa commented Jan 30, 2023

codecov bot commented Jan 30, 2023 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

✨ Added a framework to represent and handle SiDB defects #103

✨ Added a framework to represent and handle SiDB defects #103

Conversation

marcelwa commented Jan 30, 2023

codecov bot commented Jan 30, 2023 • edited Loading

Codecov Report

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

codecov bot commented Jan 30, 2023 •

edited

Loading