Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed a bug in the clear_tile function that lost track of PI and PO count #104

Merged
merged 5 commits into from
Jan 31, 2023

Conversation

marcelwa
Copy link
Collaborator

Many thanks to @simon1hofmann for reporting!

@marcelwa marcelwa added the bug Something isn't working label Jan 30, 2023
@marcelwa marcelwa self-assigned this Jan 30, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #104 (b836e27) into main (0f2d8bb) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   93.69%   93.88%   +0.18%     
==========================================
  Files          58       58              
  Lines        6095     6099       +4     
==========================================
+ Hits         5711     5726      +15     
+ Misses        384      373      -11     
Impacted Files Coverage Δ
include/fiction/layouts/gate_level_layout.hpp 99.77% <100.00%> (+<0.01%) ⬆️
include/fiction/networks/technology_network.hpp 100.00% <100.00%> (ø)
include/fiction/utils/name_utils.hpp 100.00% <100.00%> (ø)
.../algorithms/physical_design/one_pass_synthesis.hpp 88.38% <0.00%> (-0.36%) ⬇️
...ude/fiction/technology/inml_topolinano_library.hpp 89.52% <0.00%> (+6.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f2d8bb...b836e27. Read the comment docs.

@marcelwa marcelwa merged commit 863b5f4 into main Jan 31, 2023
@marcelwa marcelwa deleted the clear-tile-fix branch January 31, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant