✨ Added a framework for accurate and efficient simulation of SiDB logic #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as SiDB surface defects
…e types on certain tiles
…ilation error that would occur on compilers other than GCC
…libraries as well as a function that utilizes this information and maps it against an SiDB surface to blacklist tiles
…lysis, and the new get_functional_implementations interface of gate libraries
…lus values for electrical charge, electric permittivity, and Thomas-Fermi screening distance
…emory. This should fix out-of-memory errors and consequently failed compilations
…es and dot indices
…t types if implemented by the layout
…ng of coulomb values
… <coulomb> tag for uncharged defects
marcelwa
requested changes
Feb 2, 2023
include/fiction/algorithms/simulation_sidb/check_groundstate.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation_sidb/time_to_solution.hpp
Outdated
Show resolved
Hide resolved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
include/fiction/algorithms/simulation_sidb/time_to_solution.hpp
Outdated
Show resolved
Hide resolved
marcelwa
reviewed
Feb 2, 2023
include/fiction/algorithms/simulation_sidb/time_to_solution.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation_sidb/check_groundstate.hpp
Outdated
Show resolved
Hide resolved
…ibution_surface` objects
…o groundstate_simulation_sidb
…o groundstate_simulation_sidb
…arameters and simulation parameters).
marcelwa
approved these changes
Feb 3, 2023
| if (!candidates.empty()) | ||
| { | ||
| const auto random_index = | ||
| static_cast<uint64_t>(std::rand()) % // NOLINT: we use rand() due to its performance advantage; we do |
There was a problem hiding this comment.
warning: rand() has limited randomness; use C++11 random library instead [cert-msc30-c]
=
^| if (!candidates.empty()) | ||
| { | ||
| const auto random_index = | ||
| static_cast<uint64_t>(std::rand()) % // NOLINT: we use rand() due to its performance advantage; we do |
There was a problem hiding this comment.
warning: function is not thread safe [concurrency-mt-unsafe]
=
^
marcelwa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Added a framework for accurate and efficient simulation of SiDB logic.