Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed several I/O issues #111

Merged
merged 3 commits into from
Feb 3, 2023
Merged

🐛 Fixed several I/O issues #111

merged 3 commits into from
Feb 3, 2023

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Feb 3, 2023

Some filenames would get lost when writing layouts or networks. Also, printed ASCII layouts would look weird. Both have been fixed.

@marcelwa marcelwa added the bug Something isn't working label Feb 3, 2023
@marcelwa marcelwa self-assigned this Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #111 (d6f82fb) into main (fe7b92a) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   93.82%   93.89%   +0.07%     
==========================================
  Files          75       75              
  Lines        6926     6928       +2     
==========================================
+ Hits         6498     6505       +7     
+ Misses        428      423       -5     
Impacted Files Coverage Δ
include/fiction/io/print_layout.hpp 93.45% <100.00%> (+0.12%) ⬆️
.../algorithms/physical_design/one_pass_synthesis.hpp 90.27% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe7b92a...d6f82fb. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa merged commit 4808ffd into main Feb 3, 2023
@marcelwa marcelwa deleted the io-fixes branch February 3, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant